Private data and timeouts were lost in empty plans #21814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simpleDiff is only called from the grpc_provider, and we always need to make sure the timeouts are encoded in the private data.
Load private data for read, so the resource can get it's configured timeouts if they exist. Ensure PlanResourceChange returns the saved private data when there is an empty diff. Handle the timeout decoding into Meta in the PlanResourceChange, so that it's always there for later operations.
apparentlymart
approved these changes
Jun 20, 2019
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeouts needs to always exist in the private data with the new protocol, since not all helper/schema operations load the combined config+defaults at the correct time. The private data was lost in PlanResourceChange when there was no diff, which means there was no
diff.Metato encode them into. Thereadtimeouts were also not decoded duringReadResource, so make sure to insert them from the private data.