remote-state/pg: skip schema creation instruction if exists

[yanndegat]

• add skip_schema_creation option
• add sanity check to avoid situations where postgres users
  hasn't been granted the "CREATE SCHEMA" right

closes #21604

Signed-off-by: yann degat [email protected]

[pselle]

This is looking good! Question: the current test that is added covers if the schema already exists and the setting is set to true -- what will happen (and should we have a test to cover?) if the schema does not exist and the setting is set to true?

[yanndegat]

This is looking good! Question: the current test that is added covers if the schema already exists and the setting is set to true -- what will happen (and should we have a test to cover?) if the schema does not exist and the setting is set to true?

hi @pselle

thanks a lot for your review
i'm quite disappointed because what you suggest (test the case when it should fail) seemed to be very easy to impl at first glance, but in fact i'm quite stuck because the whole logic is done
into the backend/testing.go:TestBackendConfig func

and inside this function, theres a call to t.Fatal(), which i cant "recover()"
do you know any way to catch this error other than duplicating the whole TestBackendConfig into my unit test ?

[pgaxatte]

Hello,

Any news on this PR?
It seems to solve an issue of mine too.

[jbardin]

@mars, Just verifying if this looks OK for you too. Thanks!

[mars]

Great to see this improvement @yanndegat 🙌

I left a few suggestions that are not blockers but would be great to see accepted into the PR.

[yanndegat]

hello @mars & @jbardin

thanks a lot for your reviews

i've just taken your suggestions into account an pushed them

thanks again

regards

[yanndegat]

hi @mars & @jbardin

any news on this PR?

thanks again

[mildwonkey]

Thanks for taking a look, @mars , and for making the suggested updates @yanndegat !

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.