Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command/show (plan -json): fix panic #21541

Merged
merged 2 commits into from
Jun 3, 2019
Merged

Conversation

mildwonkey
Copy link
Contributor

We were somewhat inconsistent with return values in "after_unknown". This commit fixes that by removing some redundant (and panicky) code.

Fixes #21415 (via #21448)

With bonus fixes: typo, embarrassing debug code.

afterUnknown should return only bools, not values.
@mildwonkey mildwonkey requested a review from a team May 31, 2019 16:16
the plan output was somewhat inconsistent with return values for
"after_unknown". This strives to fix that. If all "after" values are
known, return an empty object instead of iterating over values.

Also fixing some typos and general copypasta.
@mildwonkey mildwonkey force-pushed the mildwonkey/b-show-plan-json branch from 4dbd1d4 to 6106c62 Compare May 31, 2019 16:34
@mildwonkey mildwonkey merged commit 65fc037 into master Jun 3, 2019
@mildwonkey mildwonkey deleted the mildwonkey/b-show-plan-json branch June 3, 2019 12:15
@ghost
Copy link

ghost commented Jul 25, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform show -json crash
2 participants