Fix False Error when no Outputs are Defined

[rudolphjacksonm]

Addresses #18975 -- terraform returns an error when there are no outputs defined. This should arguably exit with a return code of 0 and simply log that there were no outputs defined.

There are probably better ways of doing this but I saw the issue was sitting around for a bit and thought I'd take a stab at it!

[hashicorp-cla]

All committers have signed the CLA.

[apparentlymart]

Hi @rudolphjacksonm! Thanks for working on this, and sorry for the slow response.

I'm afraid that I ended up seeing and reviewing #23008 before I noticed that you'd made a similar change earlier, and so I've since merged that change which ended up being the same as what you proposed here. To recognize your contribution I've edited the changelog to refer to both #23008 and to this PR, since both describe the same improvement. The change should be included in the next release of Terraform.

Because the other PR is already merged, I'm going to close this one now. Thanks again for working on this, and sorry I didn't see it before now.

[getSurreal]

The change for c.Ui.Error -> c.Ui.Output is missing from #23008 and should be included.

[apparentlymart]

Hi @getSurreal! Thanks for pointing out that difference.

The message is intentionally still going to c.Ui.Error in what we merged because then redirecting the output to a file will capture an empty result in the empty case, rather than an error message.

This text is now essentially a warning message, even though it's not annotated as one, and we conventionally send warning messages to stderr.

[getSurreal]

thanks for explaining that

[getSurreal]

Sending warnings to stderr, does cause us to change our pipelines to not fail on stderr, which I don't think is a good thing. Now something more serious could slip through accidentally.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.