provider/aws: support ec2 termination protection #1988
Conversation
|
Weird double negative weirdness here. I see its the API field name... but ugh. LGTM |
| @@ -629,6 +674,27 @@ resource "aws_instance" "foo" { | |||
| } | |||
| ` | |||
|
|
|||
| func testAccInstanceConfigDisableAPITermination(val bool) string { | |||
|
Yeah agreed, decided to take the "throw up your hands and map it through" approach and link the AWS docs right away. I figure trying to make it clearer at TF layer will only cause sad edge cases of major confusion. |
|
Failure is unrelated, merging through it so I don't leave this dangling. |
provider/aws: support ec2 termination protection
| ami = "ami-4fccb37f" | ||
| instance_type = "m1.small" | ||
| subnet_id = "${aws_subnet.foo.id}" | ||
| disable_api_termination = %t |
There was a problem hiding this comment.
This is just boolean interpolation in Sprintf 👍
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
closes #1233