Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend/remote: Swift Authentication Update #18671

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

jtopjian
Copy link
Contributor

For #18569

This commit updates the authentication configuration for the Swift
remote.

Support for cross-domain authentication has been added and mapping
environment variables to the correct domain settings has been
fixed.

In addition, support for clouds.yaml files has been added.

The bulk of the files are from a mass vendor update. Sorry about that.

Upgrade Notes:

We applied this fix to the OpenStack Provider back in April/May and noticed the following:

The majority of users will not see an issue, especially those who authenticate entirely via environment variables.

Users who have modified/altered their auth settings to account for the prior behavior might have to change their auth settings to what they should have been all along.

There's always the possibility that a user will run into some difficulty or even a bug. Please ping me on any report and I can investigate.

@defo89
Copy link

defo89 commented Jun 7, 2019

Hi @jtopjian, I appreciate your effort to fix the issues with Swift remote backend. In fact, your fix enables us to use Swift in our environment.

I was wondering whether we can expect this PR to be merged into next 0.11 and 0.12 release or maybe you need help with something to get it through?

@jtopjian
Copy link
Contributor Author

jtopjian commented Jun 7, 2019

I was wondering whether we can expect this PR to be merged into next 0.11 and 0.12 release or maybe you need help with something to get it through?

Thanks for the poke. I'll find some time to rebase this PR and look into getting it merged.

This commit updates the authentication configuration for the Swift
remote.

Support for cross-domain authentication has been added and mapping
environment variables to the correct domain settings has been
fixed.

In addition, support for clouds.yaml files has been added.
@jtopjian jtopjian force-pushed the backend-swift-auth-update branch from 26174c8 to 289a286 Compare June 8, 2019 03:33
@jtopjian
Copy link
Contributor Author

jtopjian commented Jun 8, 2019

This should be good to go. The comments at the beginning of this PR are still true.

To clarify the following:

Users who have modified/altered their auth settings to account for the prior behavior might have to change their auth settings to what they should have been all along.

The user is not at fault here. It was entirely due to the backend OpenStack library. The changes in this PR will allow a user to authenticate as they would with any other OpenStack compatible app/tool.

=== RUN   TestBackend_impl
--- PASS: TestBackend_impl (0.00s)
=== RUN   TestBackendConfig
--- PASS: TestBackendConfig (0.43s)
=== RUN   TestBackend
--- PASS: TestBackend (6.07s)
=== RUN   TestBackendArchive
--- PASS: TestBackendArchive (28.58s)
=== RUN   TestRemoteClient_impl
--- PASS: TestRemoteClient_impl (0.00s)
=== RUN   TestRemoteClient
--- PASS: TestRemoteClient (0.53s)

@apparentlymart apparentlymart merged commit d8343aa into hashicorp:master Jun 12, 2019
@ghost
Copy link

ghost commented Jul 25, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants