Add support for HTTP proxy env vars.

[xocasdashdash]

Added a minimal transport to the artifactory client so that it support proxy environment variables. This should fix this issue #9403 .

Upstream there's this issue opened lusis/go-artifactory#9 but I think there might need to be some refactor on terraform's side to support the latest client.

[a2ron]

👍

[xocasdashdash]

Also I can confirm that this fix works and makes TF follow the http_proxy and https_proxy env vars.

[apparentlymart]

Thanks for working on this @xocasdashdash!

This seems like a good change, that we can merge. However, it is unfortunately likely to conflict with ongoing work in our 0.12 major feature development branch, so I'd like to pause on merging for the moment until we are able to land that branch into master. I expect it'll be more straightforward to update this relatively-small commit in the case of conflicts (which we'd be happy to do when the time comes) than to handle another conflict in the more-complex refactoring we've been working on for 0.12.

Due to the scale of the work in progress it's likely take a while longer to get the development branch in a shape ready to merge. Once we have merged it we plan to take a second look over the pending PRs and see what other changes we are reasonable to include in the 0.12 release.

Thanks again, and sorry for the delay while we work through these other changes.

[xocasdashdash]

@apparentlymart ok! I'll keep my eye out when you land the changes on master so I'll rebase those changes in. I do believe that it might make sense to try to respect the proxy vars whenever possible in all the providers.

[xocasdashdash]

@apparentlymart Hi! I've updated with the latest release from origin/master. Do you think this change can make it into the 0.11.9 release?

[xocasdashdash]

Hi @apparentlymart !
Can I get some feedback on this? Anything else I can do for this to be merged?

[jbardin]

Hi @xocasdashdash,

Thanks for the PR. The addition of the proxy setting seems like a good idea, but your transport is missing a number of parameters. Rather than setting them here, you can fetch a new configured transport using: https://godoc.org/github.com/hashicorp/go-cleanhttp#DefaultPooledTransport

[xocasdashdash]

I'll make the change right now!

[apparentlymart]

Hi @xocasdashdash!

Sorry for the delay here. This looks great to me and I'm going to merge it now.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.