Putting GITHUB_TOKEN in terraform config for aws_codepipeline

[yacinehmito]

When using AWS CodePipeline, if you want to fetch your source code from GitHub, you need to run terraform apply with the environment variable GITHUB_TOKEN (whose value should be a previously generated OAuth token).

This kinda goes against Terraform's philosophy. Would it be more sensible to have a parameter for the resource aws_codepipeline to set that token? Is there a compelling reason to use an environment variable instead?

I'm starting the discussion. If we end up deciding on a parameter I'm willing to have a go at a PR.

[yacinehmito]

Closing in favor of hashicorp/terraform-provider-aws#2796

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.