terraform: copy RawConfigs to avoid races #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| result, err := NewRawConfig(r.Raw) | ||
| if err != nil { | ||
| panic("copy failed: " + err.Error()) | ||
| } |
There was a problem hiding this comment.
I panic here because if the *RawConfig was made once, it shouldn't fail ever again. It is a pure function in that way.
mitchellh
added a commit
that referenced
this pull request
Apr 9, 2015
terraform: copy RawConfigs to avoid races
|
🐎 👍 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1416 probably
This adds a
Copymethod to*config.RawConfigthat performs a parallel-safe copy. The reason this is necessary is because*config.RawConfig.Interpolatehas a slight race in the way it reads from and writes tor.configat the same time.While I couldn't come up with a test case to prove it, I'm very confident this is what caused #1416. The key there being that in his repro, one of them isn't interpolated at all. I think this is because it wrote
r.configproperly but then another interpolation overwrote it with a raw version, and interpolation didnt' see those values.I can't be 100% sure. I couldn't reproduce the bug, but looking over the code this was the only shared state that I could find anywhere.