provider/aws: Fix issue in updating Route 53 records on refresh/read. #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Route 53 records were silently erroring out when saving the records returned from AWS, because they weren't being presented as an array of strings like we expected.
| d.Set("records", record.ResourceRecords) | ||
| err := d.Set("records", flattenResourceRecords(record.ResourceRecords)) | ||
| if err != nil { | ||
| log.Printf("[DEBUG] Error setting records for: %s, error: %#v", en, err) |
There was a problem hiding this comment.
Should we return this error instead of just logging it?
There was a problem hiding this comment.
Totally wasn't sure on what to do there. I'm cool with bubbling up the error
|
I've broken an acceptance test with TXT records here, fixing... |
|
Updated to fix regression with TXT records. @phinze take a gander when you get a minute |
ghost
mentioned this pull request
|
Route53 API still sad, but LGTM |
|
👍 |
catsby
added a commit
that referenced
this pull request
Apr 9, 2015
provider/aws: Fix issue in updating Route 53 records on refresh/read.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Route 53 records were silently erroring out when saving the records returned
from AWS, because they weren't being presented as an array of strings like we
expected.
This PR Introduces
flattenResourceRecordstostructure.go, used to flatten[]route53.ResourceRecordinto an array of strings and correctly update the local state of records. We also no longer silently ignore this error.This basically fixes #1413, in such that the local state is updated, and subsequent applying of
destroywill actually destroy the record.