Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a root_block_device forces resource refresh in AWS #1204

Closed
jaxxstorm opened this issue Mar 14, 2015 · 8 comments
Closed

Adding a root_block_device forces resource refresh in AWS #1204

jaxxstorm opened this issue Mar 14, 2015 · 8 comments

Comments

@jaxxstorm
Copy link

I've added a root block device to an ec2 resource

root_block_device {
    device_name = "/dev/sda"
    volume_type = "standard"
    volume_size = 50
  }

This seems to cause a resource refresh each time:

ami:                                       "ami-55d14d22" => "ami-55d14d22"
    availability_zone:                         "eu-west-1a" => "<computed>"
    block_device.#:                            "1" => "<computed>"
    instance_type:                             "m3.xlarge" => "m3.xlarge"
    private_dns:                               "ip-172-24-1-32.eu-west-1.compute.internal" => "<computed>"
    private_ip:                                "172.24.1.32" => "<computed>"
    public_dns:                                "" => "<computed>"
    public_ip:                                 "" => "<computed>"
    root_block_device.#:                       "0" => "1"
    root_block_device.0.delete_on_termination: "" => "1" (forces new resource)
    root_block_device.0.device_name:           "" => "/dev/sda" (forces new resource)
    root_block_device.0.iops:                  "" => "<computed>"
    root_block_device.0.volume_size:           "" => "50" (forces new resource)
    root_block_device.0.volume_type:           "" => "standard" (forces new resource)
    security_groups.#:                         "1" => "1"
    security_groups.1730728398:                "sg-b1c9b0d4" => "sg-b1c9b0d4"
    subnet_id:                                 "subnet-7eb82a1b" => "subnet-7eb82a1b"
    tenancy:                                   "default" => "<computed>"
@phinze
Copy link
Contributor

phinze commented Mar 14, 2015

Thanks for the report - I'll take a look at this sometime today.

@jaxxstorm
Copy link
Author

@phinze any love?

@phinze
Copy link
Contributor

phinze commented Mar 18, 2015

Whoops sorry - dropped the ball on this. I'm doing my best to finish landing the beast that is #1045 which I'll make sure takes care of this issue. 👍

@phinze
Copy link
Contributor

phinze commented Mar 18, 2015

@jaxxstorm actually, looking more closely at your output - the root device is typically /dev/sda1 - if you change the device_name to that, does the persistent refreshing stop?

@jaxxstorm
Copy link
Author

@phinze, afraid not :(

* Error launching source instance: logicalType cannot be modified on root device
Error applying plan:

1 error(s) occurred:

* 1 error(s) occurred:

* 1 error(s) occurred:

* 1 error(s) occurred:

* Error launching source instance: logicalType cannot be modified on root device

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.

@phinze
Copy link
Contributor

phinze commented Mar 19, 2015

@jaxxstorm now that #1045 has finally landed - can you give this another shot for me?

@jaxxstorm
Copy link
Author

@phinze initial checks seem to have fixed this completely! Thanks a bunch! I'll close this out

@ghost
Copy link

ghost commented May 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants