Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/vapp_entity: Add vapp_entity resource #640

Merged
merged 2 commits into from
Oct 18, 2018
Merged

r/vapp_entity: Add vapp_entity resource #640

merged 2 commits into from
Oct 18, 2018

Conversation

bill-rich
Copy link
Contributor

No description provided.

@bill-rich bill-rich requested a review from a team October 11, 2018 00:20
@ghost ghost added the size/xxl Relative Sizing: Extra-Extra-Large label Oct 11, 2018
bflad
bflad approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some non-blocking nits once passing acceptance testing output is shown. 👍

website/docs/r/vapp_entity.html.markdown Outdated
Provides a vSphere vApp entity resource. This can be used to describe the behavior of an entity (virtual machine or sub-vApp container) in a vApp container.
---

# vsphere\_vapp\_entity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Forward slashes in documentation headers are no longer required

website/docs/r/vapp_entity.html.markdown
---
layout: "vsphere"
page_title: "VMware vSphere: vsphere_vapp_entity"
sidebar_current: "docs-vsphere-resource-compute-vapp-entity"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a sidebar link in website/vsphere.erb?

website/docs/r/vapp_entity.html.markdown Outdated
* `stop_delay` - (Optional) Delay in seconds before continuing with the next
entity in the order sequence. This is only used if the stopAction is
guestShutdown. Default: 120
* `wait_for_guest` - (Optional) Determines if the VM should be marked as being
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Looks like some tabs found their way into here

website/docs/r/vapp_entity.html.markdown Outdated
```

The above would import the vApp entity that governs the behavior of the virtual
machine with a MOID of vm-123 in the vApp container with the MOID res-456.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Might be better to spell out managed object ID instead of its abbreviation

@bill-rich
Copy link
Contributor Author 

make testacc TEST=github.com/terraform-providers/terraform-provider-vsphere/vsphere TESTARGS="-count=1 -run=TestAccResourceVSphereVAppEntity"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test github.com/terraform-providers/terraform-provider-vsphere/vsphere -v -count=1 -run=TestAccResourceVSphereVAppEntity -timeout 240m
=== RUN   TestAccResourceVSphereVAppEntity_basic
--- PASS: TestAccResourceVSphereVAppEntity_basic (19.00s)
=== RUN   TestAccResourceVSphereVAppEntity_nonDefault
--- PASS: TestAccResourceVSphereVAppEntity_nonDefault (17.10s)
=== RUN   TestAccResourceVSphereVAppEntity_update
--- PASS: TestAccResourceVSphereVAppEntity_update (25.87s)
=== RUN   TestAccResourceVSphereVAppEntity_multi
--- PASS: TestAccResourceVSphereVAppEntity_multi (20.35s)
=== RUN   TestAccResourceVSphereVAppEntity_multiUpdate
--- PASS: TestAccResourceVSphereVAppEntity_multiUpdate (29.40s)
=== RUN   TestAccResourceVSphereVAppEntity_import
--- PASS: TestAccResourceVSphereVAppEntity_import (26.93s)
PASS
ok  	github.com/terraform-providers/terraform-provider-vsphere/vsphere	138.672s

@bill-rich bill-rich merged commit 5c4a0f2 into master Oct 18, 2018
@bill-rich bill-rich deleted the f-resource-vapp-entity branch October 18, 2018 17:47
@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
size/xxl Relative Sizing: Extra-Extra-Large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bill-rich @bflad