Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/virtual_disk: update tests #635

Merged
merged 2 commits into from
Oct 18, 2018
Merged

r/virtual_disk: update tests #635

merged 2 commits into from
Oct 18, 2018

Conversation

bill-rich
Copy link
Contributor

No description provided.

@bill-rich bill-rich requested a review from a team October 8, 2018 01:05
@ghost ghost added the size/xl Relative Sizing: Extra-Large label Oct 8, 2018
bflad
bflad approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the acceptance testing output is shown as passing

vsphere/resource_vsphere_virtual_disk_test.go
datastore = "${data.vsphere_datastore.ds.name}"
}
`,
os.Getenv("VSPHERE_DATACENTER"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: It might be more clear to reference these in the acceptance test functions themselves so its near the PreCheck declaration and then require the variables be passed into the wrapping function for the fmt.Sprintf() so its not possible to forget them, but that's generally how we do it in the AWS provider. Either way is probably fine!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually like your way more as it would make the config functions more reusable. At this point, I'm going to just stick with this way just to keep it consistent with the other vsphere tests.

@bill-rich
Copy link
Contributor Author 

make testacc TEST=github.com/terraform-providers/terraform-provider-vsphere/vsphere TESTARGS="-count=1 -run=TestAccResourceVSphereVirtualDisk"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test github.com/terraform-providers/terraform-provider-vsphere/vsphere -v -count=1 -run=TestAccResourceVSphereVirtualDisk -timeout 240m
=== RUN   TestAccResourceVSphereVirtualDisk_basic
--- PASS: TestAccResourceVSphereVirtualDisk_basic (9.18s)
=== RUN   TestAccResourceVSphereVirtualDisk_multi
--- PASS: TestAccResourceVSphereVirtualDisk_multi (10.37s)
=== RUN   TestAccResourceVSphereVirtualDisk_multiWithParent
--- PASS: TestAccResourceVSphereVirtualDisk_multiWithParent (11.46s)
=== RUN   TestAccResourceVSphereVirtualDisk_withParent
--- PASS: TestAccResourceVSphereVirtualDisk_withParent (9.84s)
PASS
ok  	github.com/terraform-providers/terraform-provider-vsphere/vsphere	40.862s

@bill-rich bill-rich merged commit 40873d1 into master Oct 18, 2018
@bill-rich bill-rich deleted the f-virtual-diskupdate-tests branch October 18, 2018 18:06
@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
size/xl Relative Sizing: Extra-Large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bill-rich @bflad