Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing not supported for vsphere_host_port_group and vsphere_host_virtual_switch #477

Closed
warrn opened this issue Apr 15, 2018 · 4 comments
Labels
enhancement Type: Enhancement stale Status: Stale

Comments

@warrn
Copy link

warrn commented Apr 15, 2018

Terraform Version

Terraform v0.11.7
+ provider.vsphere v1.4.0

Affected Resource(s)

  • vsphere_host_port_group
  • vsphere_host_virtual_switch

Important Factoids

Currently working towards onboarding a previously existing esxi cluster with terraform. What attracted me most to terraform was the ability to work in systems that previously existed without provisioning software, which is important for my use case.

I see that the addition of host_port_group and host_virtual_switch was added recently (Aug. 2017 if the pull request is correct #138 ), and importing was omitted while being said it would be added later. Has there been any work towards this? If not I'm possibly interested in implementing the functionality.

Thanks for any information that you can provide. So far I'm really enjoying working with this tool, so I hope I'm able to continue using it.

@vancluever vancluever added the enhancement Type: Enhancement label Apr 15, 2018
@warrn
Copy link
Author

warrn commented Apr 17, 2018

Any information on this?

@vancluever
Copy link
Contributor

@warrn we are pretty busy with the push to 1.5.0 which will be fleshing out the rest of the cluster coverage for the provider (compute clusters/DRS/HA/overrides and specific cluster rules), so it will probably be a while before we have time here to work on this enhancement. If you have the time, by all means I'd love to review and merge a PR with this functionality!

With how the IDs are constructed for vsphere_host_port_group and vsphere_host_virtual_switch, you might be able to get away with ImportStatePassthrough. I'd give that a shot first as it would be the easiest way to get import in. Make sure when you are updating the documentation that you include instructions for fetching the appropriate MOIDs for hosts, similar to what we have for the datastore resources.

Thank you very much for being willing to take this on!

@hashibot
Copy link

This issue has been open 180 days with no activity. If this issue is reproducible with the latest version of the provider and with Terraform 0.12, please comment. Otherwise this issue will be closed in 30 days.

@hashibot hashibot added the stale Status: Stale label Apr 24, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Type: Enhancement stale Status: Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants