d/virtual_machine: Nil check for empty VM configuration #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles a crash case when there is no configuration for a specified virtual machine. This unfortunately is an edge case and hard for us to test for, as cases like this where the VM lack a config attribute are usually due to issues with importing the VM, or an orphaned virtual machine in vSphere.
vancluever
added a commit
that referenced
this pull request
Apr 13, 2018
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles a crash case when there is no configuration for a specified
virtual machine.
This unfortunately is an edge case and hard for us to test for, as cases
like this where the VM lack a
configattribute are usually due to issueswith importing the VM, or an orphaned virtual machine in vSphere.
Ref: #432