r/virtual_machine: Fix multiple change operations to a single device #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to how the DeviceChange struct works in API, it's possible to end up setting up a list of DeviceChange operations that possibly point to the same underlying virtual device. In this instance, with our logic, any subsequent operations that result in a device change will end up changing all operations before it into the same state as the most current version of that virtual device, causing an invalid operation. This can be seen in a scenario that a VM is cloned from template, with both the SCSI bus type and disk size changing at the same time: * The SCSI type change will add an operation that changes the controller the disk is attached to. * The second operation will change the size of the virtual disk. Both of these operations will operate on the same VirtualDisk device instance and if the structure is not duplicated, this will result in the first device change operation being identical to the second, causing the subsequent reconfigure operation to fail.
Closed
2 tasks
paultyng
approved these changes
Jan 25, 2018
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to how the DeviceChange struct works in API, it's possible to end up
setting up a list of DeviceChange operations that possibly point to
the same underlying virtual device. In this instance, with our logic,
any subsequent operations that result in a device change will end up
changing all operations before it into the same state as the most
current version of that virtual device, causing an invalid operation.
This can be seen in a scenario that a VM is cloned from template, with
both the SCSI bus type and disk size changing at the same time:
the disk is attached to.
Both of these operations will operate on the same VirtualDisk device
instance and if the structure is not duplicated, this will result in the
first device change operation being identical to the second, causing the
subsequent reconfigure operation to fail.