Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/virtual_machine: Assert timezone using stdlib and TF core #251

Closed
vancluever opened this issue Nov 30, 2017 · 2 comments
Closed

r/virtual_machine: Assert timezone using stdlib and TF core #251

vancluever opened this issue Nov 30, 2017 · 2 comments
Labels
enhancement Type: Enhancement stale Status: Stale

Comments

@vancluever
Copy link
Contributor

vancluever commented Nov 30, 2017

Reference: #244 (comment)

Right now we are validating this using StringMatch, but a much cleaner way would be to validate using LoadLocation in stdlib, which loads data from the IANA TZ database.

This should be a validation function in TF core: https://github.com/hashicorp/terraform/blob/master/helper/validation/validation.go

@vancluever vancluever changed the title [TODO] r/virtual_machine: Assert timezone using stdlib and TF core r/virtual_machine: Assert timezone using stdlib and TF core Nov 30, 2017
@vancluever vancluever added the enhancement Type: Enhancement label Nov 30, 2017
@hashibot
Copy link

This issue has been open 180 days with no activity. If this issue is reproducible with the latest version of the provider and with Terraform 0.12, please comment. Otherwise this issue will be closed in 30 days.

@hashibot hashibot added the stale Status: Stale label Apr 25, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Type: Enhancement stale Status: Stale
Projects
None yet
Development

No branches or pull requests

2 participants