ept_rvi_mode and hv_mode Changing Value after v2.8.0 update

[zachary-plencner]

Community Guidelines

• I have read and agree to the HashiCorp Community Guidelines .
• Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
• Do not leave "+1" or other comments that do not add relevant information or questions.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Terraform

v1.8.2

Terraform Provider

v2.8.0

VMware vSphere

v7.0.3

Description

Probably related to:
#1902
and
#2172

After this provider was updated today our pipelines that utilize this are having issues. Terraform wants to reset the value of ept_rvi_mode and hv_mode to null, when they were previously being detected as something else:

These properties are not being set anywhere in our .tf files. It is creating issues since in order for Terraform to change this value (to "null" apparently) it wants to power off the VM, which is not desirable since it manages systems that are in production.

Affected Resources or Data Sources

resource/vsphere_virtual_machine

Terraform Configuration

n/a

Debug Output

n/a

Panic Output

n/a

Expected Behavior

Detect the infrastructure as matching the Terraform state configuration and continuing.

Actual Behavior

Terraform wants to power off VM in order to reset these unmanaged properties

Steps to Reproduce

Do not set the above properties in .tf file
Deploy a machine using provider <=v2.7.0
Rerun Terraform using provider v2.8.0

Environment Details

No response

Screenshots

No response

References

No response

[github-actions]

Hello, zachary-plencner! 🖐

Thank you for submitting an issue for this provider. The issue will now enter into the issue lifecycle.

If you want to contribute to this project, please review the contributing guidelines and information on submitting pull requests.

[tenthirtyam]

@stoyan-hristov - can you please take a look into this one based on the prior changes?

[stoyan-hristov]

@spacegospod - can you take a look?

[spacegospod]

@tenthirtyam @zachary-plencner This is caused by #2172

Prior to 2.8.0 the provider used to always override the values for these properties which caused it to run in-place updates on VMs even when nothing had changed.

The in-place update that you're observing on your pipeline should only occur once.
In my opinion 2.8.0 behaves correctly and 2.7.0 is faulty.

I will revert PR 2172 until I figure out how we can apply it without causing VM power ops events

[tenthirtyam]

This has been reverted in v2.8.1.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.