r/virtual_machine: Allow tuning of customization waiter #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current value is hardcoded at 10 minutes, which has been possibly causing some issues. This allows for the modification of the timeout - so that it can be change to be a later value if customization takes a long time (possible on systems with older hardware or non-SSD disk), or disabled altogether to eliminate it as a source of problems. Note that disabling the waiter pushes waiting over to the guest networking waiter, which is currently also hardcoded at 5 minutes. Modification of this attribute to a different value will require a state migration (to translate true => 5min and false => <disabled>) which is a bit more of an involved change, so I want to take a wait-and-see approach to see if it is required, especially considering the resource will be undergoing a larger refactor very soon.
vancluever
force-pushed
the
f-vm-customization-timeout
branch
from
5db9787
to
25bfc1b
Compare
|
Thanks @mbfrahry! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current value is hardcoded at 10 minutes, which has been possibly
causing some issues. This allows for the modification of the timeout -
so that it can be change to be a later value if customization takes a
long time (possible on systems with older hardware or non-SSD disk), or
disabled altogether to eliminate it as a source of problems.
Note that disabling the waiter pushes waiting over to the guest
networking waiter, which is currently also hardcoded at 5 minutes.
Modification of this attribute to a different value will require a state
migration (to translate
true=>5minandfalse=><disabled>) which is abit more of an involved change, so I want to take a wait-and-see
approach to see if it is required, especially considering the resource
will be undergoing a larger refactor very soon.
Ref: #183