Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical Debt: Harmonize the timeouts throughout the provider #1698

Closed
4 tasks done
tenthirtyam opened this issue Jul 26, 2022 · 3 comments
Closed
4 tasks done

Technical Debt: Harmonize the timeouts throughout the provider #1698

tenthirtyam opened this issue Jul 26, 2022 · 3 comments
Labels
community/contribution Community: Contribution Help Wanted enhancement Type: Enhancement provider/technical-debt Provider: Technical Debt provider Type: Provider stale Status: Stale

Comments

@tenthirtyam
Copy link
Collaborator

Community Guidelines

  • I have read and agree to the HashiCorp Community Guidelines .
  • Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
  • Do not leave "+1" or other comments that do not add relevant information or questions.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

The provider really doesn't implement the canonical setup for handling timeouts. https://www.terraform.io/plugin/sdkv2/resources/retries-and-customizable-timeouts

The provider has a private defaultAPITimeout which doesn't remain a default. In the provider configuration, it gets set to the provider block attribute api_timeout. The provider also seems to use a public constant provider.DefaultAPITimeout which does remain to the hardcoded 5 minute timer..

Use Case(s)

Harmonize the timeouts throughout the provider.

Potential Terraform Provider Configuration

No response

References

#1645

@tenthirtyam tenthirtyam added enhancement Type: Enhancement provider/technical-debt Provider: Technical Debt provider Type: Provider labels Jul 26, 2022
@tenthirtyam tenthirtyam added this to the Backlog / Triage milestone Jul 26, 2022
@tenthirtyam tenthirtyam added the community/contribution Community: Contribution Help Wanted label Jul 26, 2022
@github-actions
Copy link

Marking this issue as stale due to inactivity in the past 180 days. This helps us focus on the active issues. If this issue is reproducible with the latest version of the provider, please comment. If this issue receives no comments in the next 30 days it will automatically be closed.
If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Status: Stale label Jan 23, 2023
@tenthirtyam tenthirtyam removed the stale Status: Stale label Jan 23, 2023
@github-actions
Copy link

Marking this issue as stale due to inactivity in the past 180 days. This helps us focus on the active issues. If this issue is reproducible with the latest version of the provider, please comment. If this issue receives no comments in the next 30 days it will automatically be closed.
If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Status: Stale label Jul 23, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2023
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
@tenthirtyam tenthirtyam removed this from the Backlog milestone Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community/contribution Community: Contribution Help Wanted enhancement Type: Enhancement provider/technical-debt Provider: Technical Debt provider Type: Provider stale Status: Stale
Projects
None yet
Development

No branches or pull requests

1 participant