r/virtual_machine: Increase customization timeout to 10 mins #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users have been reporting that 5 minutes is probably too short. Indeed, in our lab it takes about 3 mins to complete (using nested ESXi and datastores that are on SSDs), so this is definitely reasonable. Adjusting this to 10 minutes which should hopefully be good for the vast majority of cases. If need be, we can make this configurable, but then we are wading into provider timeout territory as well.
Should have been a const before but I'm guessing I thought it couldn't be since I was using a type, but time.Duration is an int64, so the literal ends up being able to be a constant anyway.
mbfrahry
approved these changes
Sep 19, 2017
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users have been reporting that 5 minutes is probably too short. Indeed,
in our lab it takes about 3 mins to complete (using nested ESXi and
datastores that are on SSDs), so this is definitely reasonable.
Adjusting this to 10 minutes which should hopefully be good for the vast
majority of cases. If need be, we can make this configurable, but then
we are wading into provider timeout territory as well.
Also included in this is the adjustment of
defaultAPITimeoutto a const, sincetime.Durationis an int64 and can accommodate this.Fixes #160