Add support for multiple offsets to time_offset module

[sumkincpp]

Add support for multiple offsets to time_offset

resource "time_offset" "example" {
  offset_years = 1
  offset_months = 1
}
output "one_year_and_month_from_now" {
  value = time_offset.example.rfc3339
}

Workaround right now, for example - use only one attribute, i.e. offset_months=13

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

[hashicorp-cla]

All committers have signed the CLA.

[SBGoods]

Hi @sumkincpp thank you for the contribution,
Since we currently allow practitioners to set multiple offsets in the configuration, there is a possibility that some practitioners may have these set inadvertently and this feature would result in a breaking change for them. We can consider this PR as part of a larger effort for a Time Provider major release in the future but we do not have a timeline for this at the moment. Feel free to keep this PR open if you would like, but we might not be able to review this PR in the near future.

[pascal-hofmann]

This provider has four resources and a major bug in one of them which cost me quite some time today. Why not just merge and release a new major version?

I understand that for things like terraform-provider-aws pushing new major versions requires some more planning, but I don't think it makes sense here.

[SBGoods]

Hi @sumkincpp
I've added a changelog entry and moved your doc example to the template to pass our CI check. Otherwise, this looks good to go.

Thank you for the contribution!

[pascal-hofmann]

Thanks for merging this! 🚀

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.