Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resource tfe_audit_trail_token #1488

Closed
wants to merge 9 commits into from
Closed

add resource tfe_audit_trail_token #1488

wants to merge 9 commits into from

Conversation

c4po
Copy link
Contributor

@c4po c4po commented Oct 8, 2024

Description

Add resource tfe_audit_trail_token to manage audit trail tokens in Terraform Cloud
API docs
go-tfe type

Remember to:

Testing plan

  1. Describe how to replicate
  2. the conditions
  3. under which your code performs its purpose,
  4. including example Terraform configs where necessary.

External links

Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.

Output from acceptance tests

Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.

If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.

$ TESTARGS="-run TestAccTFEWorkspace" make testacc

...

@c4po c4po marked this pull request as ready for review October 8, 2024 20:07
@c4po c4po requested a review from a team as a code owner October 8, 2024 20:07
Copy link
Contributor

@Uk1288 Uk1288 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🎉

Added some few comments below:

internal/provider/resource_tfe_audit_trail_token.go Outdated Show resolved Hide resolved
internal/provider/resource_tfe_audit_trail_token.go Outdated Show resolved Hide resolved
internal/provider/resource_tfe_audit_trail_token.go Outdated Show resolved Hide resolved
internal/provider/resource_tfe_audit_trail_token.go Outdated Show resolved Hide resolved
internal/provider/resource_tfe_audit_trail_token.go Outdated Show resolved Hide resolved
internal/provider/resource_tfe_audit_trail_token.go Outdated Show resolved Hide resolved
internal/provider/resource_tfe_audit_trail_token.go Outdated Show resolved Hide resolved
internal/provider/resource_tfe_audit_trail_token_test.go Outdated Show resolved Hide resolved
internal/provider/resource_tfe_audit_trail_token_test.go Outdated Show resolved Hide resolved
@uturunku1
Copy link
Collaborator

uturunku1 commented Oct 17, 2024

@c4po Hi Max! Thank you for your contribution! Did you have the chance to consider Ukeme's PR review and do you have any questions that we can help with?

@c4po c4po requested a review from Uk1288 November 12, 2024 16:42
@c4po
Copy link
Contributor Author

c4po commented Nov 14, 2024

@uturunku1 @Uk1288 Can you have a review again?

@glennsarti
Copy link
Contributor

Hi @c4po . Thanks for putting up this PR! With your permission we'd like to take your commits and then convert the resource to the newer TF Plugin SDK. We're trying to avoid adding newer code that uses the old SDK.

@glennsarti
Copy link
Contributor

Closing in favour of #1533

@glennsarti glennsarti closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants