Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment knob for automount_service_account_token #364

Closed
dolvany opened this issue Mar 20, 2019 · 3 comments
Closed

deployment knob for automount_service_account_token #364

dolvany opened this issue Mar 20, 2019 · 3 comments

Comments

@dolvany
Copy link

dolvany commented Mar 20, 2019

It seems that automount_service_account_token defaults to false on a deployment with no knob to change it. Doesn't this render the same knob useless on a service account since the deployment setting takes precedence? Is there a compelling reason that this knob does not exist for a deployment?

@mbarrien
Copy link
Contributor

See response in #38 (comment) to explain reasoning for this and workaround.

@dolvany
Copy link
Author

dolvany commented Mar 20, 2019

I see the explanation is referencing the default service account which is not my use case, but the reasoning isn't entirely clear. Something about ambiguity, it seems. Adding a blurb to the deployment documentation may reduce the issue volume surrounding this feature omission. Otherwise, peeps are left to assume that this is a bug or oversight. Something such as automount_service_account_token (not implemented) with reasoning and a link to the workaround.

@dolvany dolvany closed this as completed Mar 20, 2019
@tdmalone
Copy link
Contributor

I was just about to create an issue about this too, after debugging it and realising what was happening.

This definitely needs to be in the documentation. @dolvany Would you be open to reopening this issue (to assist in discovery / a pointer to update the documentation)?

@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants