Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment update checks replicationcontroller instead of rollout status #210

Closed
andyvanosdale opened this issue Nov 8, 2018 · 5 comments

Comments

@andyvanosdale
Copy link
Contributor

Terraform Version

0.11.7

Affected Resource(s)

Please list the resources as a list, for example:

  • deployment

Debug Output

https://gist.github.com/enozero/9e60d362b7801b779555133241608059

Expected Behavior

It should check the status of the deployment rollout.

Actual Behavior

It check the replicationcontroller, which is not created

Steps to Reproduce

Please list the steps required to reproduce the issue, for example:

  1. terraform apply
@andyvanosdale
Copy link
Contributor Author

More details here: #101 (comment)

@andyvanosdale
Copy link
Contributor Author

I've verified locally changing the function call to waitForDeploymentReplicasFunc works perfectly. I'll submit a pull request on it.

@andyvanosdale
Copy link
Contributor Author

@alexsomesan for visibility

@alexsomesan
Copy link
Member

Thanks for documenting this and validation the proposed solution.
I'd love to take a look at that PR.

@andyvanosdale
Copy link
Contributor Author

This can be closed out!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants