r/kubernetes_service: Switch targetPort to string #154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #134
switch targetPort to string in schema
new acceptance test
update docs to reflect targetPort is optional
Fortunately HCL appears to be flexible enough that it accepts both
target_port: 80
ortarget_port: "80"
. Kubernetes has its ownIntOrString
type that will parse the stringified integer to anint
. Long story short there should be no breaking changes in anyones configs