validators: change label validation to DNS1123 subdomain #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appilon
changed the title
appilon
changed the title
radeksimko
reviewed
Apr 9, 2018
| data { | ||
| ".start" = "foo" | ||
| "mid.dle" = "foo" | ||
| "end." = "foo" |
There was a problem hiding this comment.
I don't think we run the validation function for data here, so these three examples would be better exercised perhaps in 3 separate kubernetes_secrets with appropriate metadata name.
Not a big deal though as we already exercise dot in the middle of the string.
There was a problem hiding this comment.
I will remove the data from the config since it serves no purpose in the test
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #87