Update max_history default value to 10 #1525
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Signed-off-by: locmai <[email protected]>
locmai
force-pushed
the
helm-max-history
branch
from
c949862
to
5b7c98f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the default value for max_history to 10 align with Helm upgrade https://helm.sh/docs/helm/helm_upgrade/
The default expected behavior we have from Helm is that we have 10 revisions as the default limit. Keeping it at 0 would unintentionally create too many secrets for the revisions.
Acceptance tests
Release Note
Release note for CHANGELOG:
References
Community Note