helm-framework: ModifyPlan refactor 2

[BBBmau]

Description

- [ ] refactor plan.Lint.ValueBool() to be it's own PlanModifier 974fdeb
- [for later] Perhaps we can decompose the ModifyPlan function into more discrete planModifiers on a per resource basis, i.e for version, manifest <- This is up for discussion. Since the initial implementation just seems like a lot more code than what it was previously.

• add diagnostic when we hit the “cluster unreachable” logic 833280a
• set plan.Version to the state value, rather than setting plan.Version to null (this causes a computed action the attribute) c388c75

Acceptance tests

• Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

...

References

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[JaylonmcShan03]

• The error handling is more descriptive, and uses diagnostics which is better!

• I agree, because it aligns with maintaining the correct state, preventing unnecessary recomputation (I think thats the correct wording haha) by using the previous state version if available