Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove blocks from helm_release resource schema #1507

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Remove blocks from helm_release resource schema #1507

merged 2 commits into from
Oct 23, 2024

Conversation

jrhouston
Copy link
Contributor

Description

This removes blocks from the schema and changes them to nested attributes.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@jrhouston jrhouston requested a review from a team as a code owner October 23, 2024 04:36
@JaylonmcShan03
Copy link
Contributor

Thanks for migrating from block, I believe that will get rid of unsupported block type errors we've faced in a test :)

@jrhouston jrhouston merged commit 8e884fd into helm-framework Oct 23, 2024
4 of 13 checks passed
@jrhouston jrhouston deleted the remove-blocks branch October 23, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaylonmcShan03 JaylonmcShan03 JaylonmcShan03 approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrhouston @JaylonmcShan03