Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump hcp-sdk-go and fix packer import path #307

Merged
merged 3 commits into from
May 9, 2022

Conversation

sylviamoss
Copy link
Contributor

πŸ› οΈ Description

Bump hcp-sdk-go to update the hcp packer client to the stable version of the API.

🚒 Release Note

Release note for CHANGELOG:

NONE

πŸ—οΈ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAcc_dataSourcePacker'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/... -v -run=TestAcc_dataSourcePacker -timeout 210m
?       github.com/hashicorp/terraform-provider-hcp/internal/clients    [no test files]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/consul     1.342s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/input      1.180s [no tests to run]
=== RUN   TestAcc_dataSourcePacker
--- PASS: TestAcc_dataSourcePacker (36.33s)
=== RUN   TestAcc_dataSourcePackerImage
--- PASS: TestAcc_dataSourcePackerImage (30.60s)
=== RUN   TestAcc_dataSourcePackerImage_revokedIteration
--- PASS: TestAcc_dataSourcePackerImage_revokedIteration (28.98s)
=== RUN   TestAcc_dataSourcePackerIteration
--- PASS: TestAcc_dataSourcePackerIteration (28.10s)
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider   124.953s

@sylviamoss sylviamoss requested a review from a team as a code owner May 6, 2022 09:21
@sylviamoss sylviamoss requested a review from a team May 6, 2022 09:21
go.mod Outdated
@@ -10,7 +10,7 @@ require (
github.com/google/uuid v1.3.0
github.com/hashicorp/go-cty v1.4.1-0.20200414143053-d3edf31b6320
github.com/hashicorp/go-version v1.4.0
github.com/hashicorp/hcp-sdk-go v0.18.0
github.com/hashicorp/hcp-sdk-go v0.18.1-0.20220506085537-4a8c08ea0676
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just pumped to 0.19.0, so you can pin to that: https://github.com/hashicorp/hcp-sdk-go/releases/tag/v0.19.0

Copy link
Contributor

@bcmdarroch bcmdarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ just need to bump SDK to 0.19.0

@sylviamoss sylviamoss merged commit c4a9ba6 into main May 9, 2022
@sylviamoss sylviamoss deleted the bump_hcp_sdk_go_fix_packer_import_path branch May 9, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants