Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HCP status checker #298

Merged
merged 3 commits into from
May 5, 2022
Merged

Update HCP status checker #298

merged 3 commits into from
May 5, 2022

Conversation

bcmdarroch
Copy link
Contributor

@bcmdarroch bcmdarroch commented Apr 26, 2022 •
edited
Loading

🛠️ Description

TODO BEFORE MERGE:

  • add HCP API component ID
  • update Consul component ID
  • update Vault component ID

Our status page has been updated with a new path. It also now reports a list of HCP components, rather than a single rollup component. This required some refactoring of our status page checker.

Now, when any single HCP component is reporting non-operational, the provider will the warning below with the statuses of all HCP components.

$  terraform plan        
╷
│ Warning: You may experience issues using HCP.
│ 
│   with provider["localhost/providers/hcp"],
│   on example.tf line 151, in provider "hcp":
│  151: provider "hcp" {}
│ 
│ HCP is reporting the following:
│ 
│ HCP Vault:       operational
│ HCP Packer:      operational
│ HCP API:         major_outage
│ HCP Portal:      operational
│ HCP Consul:      degraded_performance
│ 
│ Please check https://status.hashicorp.com for more details.
╵

🚢 Release Note

Release note for CHANGELOG:

* provider: provider reports all HCP component statuses [GH-298]

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccHvnOnly'

--- PASS: TestAccHvnOnly (128.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider	130.369s

@bcmdarroch bcmdarroch requested a review from a team April 26, 2022 14:14
@Dombo
Copy link

Dombo commented Apr 29, 2022

Looks good to me, thanks for the quick turnaround.

@Dombo Dombo self-requested a review April 29, 2022 08:44
Dombo
Dombo approved these changes Apr 29, 2022
View reviewed changes
Copy link

@Dombo Dombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending requested change.

internal/provider/provider.go
const statuspageHcpComponentId = "ym75hzpmfq4q"
const statuspageUrl = "https://status.hashicorp.com/api/v2/components.json"

var hcpComponentIds = map[string]string{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make @hashicorp/team-cloud-sre a codeowner of this file?

@bcmdarroch bcmdarroch mentioned this pull request Apr 29, 2022
Merged
@bcmdarroch bcmdarroch changed the title Update HCP status checker [DO NOT MERGE] Update HCP status checker May 2, 2022
bcmdarroch added 3 commits May 4, 2022 15:52
@bcmdarroch
update status handler
f07ea10 
status page now reports list of HCP components,
rather than a single rollup component
@bcmdarroch
add SRE as codeowner of provider.go
764a84c
@bcmdarroch
update finalized component IDs
62ba8f9
@bcmdarroch bcmdarroch force-pushed the update-statuspage-ids branch from 00a11e7 to 62ba8f9 Compare May 5, 2022 14:35
@bcmdarroch bcmdarroch changed the title [DO NOT MERGE] Update HCP status checker Update HCP status checker May 5, 2022
@bcmdarroch bcmdarroch merged commit 32d5022 into main May 5, 2022
@bcmdarroch bcmdarroch deleted the update-statuspage-ids branch May 5, 2022 14:39
aidan-mundy pushed a commit that referenced this pull request Sep 8, 2023
@bcmdarroch
Update HCP status checker (#298)
250d655 
* update status handler
status page now reports list of HCP components,
rather than a single rollup component

* add SRE as codeowner of provider.go

* update finalized component IDs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesdavpet jesdavpet jesdavpet approved these changes

@Dombo Dombo Dombo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcmdarroch @Dombo @jesdavpet