Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault: enable paths_filter and scaling for Plus-tier #281

Merged
merged 3 commits into from
Mar 31, 2022

Conversation

kkredit
Copy link
Contributor

@kkredit kkredit commented Mar 30, 2022

🛠️ Description

Vault: enable configuring the paths_filter on performance replicated secondaries and enable scaling of Plus-tier clusters.

🚢 Release Note

Release note for CHANGELOG:

* Vault: enable paths_filter and scaling in Plus-tier [GH-281]

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccPerformanceReplication_Validations'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/... -v -run=TestAccPerformanceReplication_Validations -timeout 120m
?       github.com/hashicorp/terraform-provider-hcp/internal/clients    [no test files]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/consul     (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/input      (cached) [no tests to run]
=== RUN   TestAccPerformanceReplication_Validations
--- PASS: TestAccPerformanceReplication_Validations (5708.86s)
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider   5709.379s

@kkredit kkredit requested a review from a team March 30, 2022 21:34
printPlusScalingWarningMsg()
primaryLink := getPrimaryLinkIfAny(d)
if primaryLink != "" {
// If the cluster is a secondary, issue the actual API request to the primary.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the behavior here is unexpected, maybe worth noting that this is a temporary workaround the API?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API changes that would enable removing this special case are not currently planned, so that kind of comment wouldn't be accurate. Okay to leave as is, or would you like more explanation in the comments?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think further explanation would help!

Copy link
Contributor

@bcmdarroch bcmdarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

@kkredit kkredit merged commit 4eb8575 into main Mar 31, 2022
@kkredit kkredit deleted the hcp-vault-perf-replication-paths-scaling branch March 31, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants