Update tests to only set CloudProvider on CreateBuild #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* There was an upstream bug that was not persisting the CloudeProvider
when included in the CreateBuild API body. Now, with the fix in place,
calling UpdateBuild with a CloudProvider set returns an
error; thus causing the tests to fail.
Tests Before Change
```
=== RUN TestAcc_dataSourcePacker
data_source_packer_image_iteration_test.go:298: unexpected UpdateBuild error, expected nil. Got [PATCH /packer/2021-04-30/organizations/{location.organization_id}/projects/{location.project_id}/builds/{build_id}][409] PackerService_UpdateBuild default &{Code:6 Details:[] Error:You cannot override a build's Cloud Provider if it has already been set. Message:You cannot override a build's Cloud Provider if it has already been set. }
data_source_packer_image_iteration_test.go:466: unexpected CreateChannel error, expected nil. Got [POST /packer/2021-04-30/organizations/{location.organization_id}/projects/{location.project_id}/images/{bucket_slug}/channels][400] PackerService_CreateChannel default &{Code:9 Details:[] Error:Error creating channel: iteration is incomplete. Message:Error creating channel: iteration is incomplete.}
data_source_packer_image_iteration_test.go:443: Step 1/1 error: Error running pre-apply refresh: exit status 1
Error: could not load the channel. something in the request is invalid.
with data.hcp_packer_image_iteration.alpine,
on terraform_plugin_test.tf line 4, in data "hcp_packer_image_iteration" "alpine":
4: data "hcp_packer_image_iteration" "alpine" {
```
Tests After Change
```
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-hcp/internal/input 0.700s [no tests to run]
=== RUN TestAcc_dataSourcePacker
--- PASS: TestAcc_dataSourcePacker (11.98s)
=== RUN TestAcc_dataSourcePacker_revokedIteration
--- PASS: TestAcc_dataSourcePacker_revokedIteration (7.75s)
=== RUN TestAcc_dataSourcePackerImage
--- PASS: TestAcc_dataSourcePackerImage (8.06s)
=== RUN TestAcc_dataSourcePackerIteration
--- PASS: TestAcc_dataSourcePackerIteration (7.77s)
=== RUN TestAcc_dataSourcePackerIteration_revokedIteration
--- PASS: TestAcc_dataSourcePackerIteration_revokedIteration (7.97s)
PASS
ok github.com/hashicorp/terraform-provider-hcp/internal/provider 43.926s
```
nywilken
force-pushed
the
fix/packer_datasource_acceptance_test
branch
from
d87efcb to
19cdc91
Compare
nywilken
changed the title
|
cc @sylviamoss for visibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an upstream bug that was not persisting the CloudeProvider when included in the CreateBuild API body. Now calling UpdateBuild with a CloudProvider returns an error; thus causing the tests to fail.
Tests Before Change
Tests After Change