Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resource_consul_cluster_root_token.go #241

Merged
merged 3 commits into from
Jan 24, 2022

Conversation

srikrishmurthy
Copy link
Contributor

Changed the description
a) Existing text about invalidation is incorrect
b) Clarified that this token is similar to the one provided in the HCP Consul UI

🛠️ Description

🚢 Release Note

Release note for CHANGELOG:

* {affected resource | docs | all}: {Brief description of change} [GH-nnnn]

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Changed the description 
a) Existing text about invalidation is incorrect
b) Clarified that this token is similar to the one provided in the HCP Consul UI
@srikrishmurthy srikrishmurthy requested a review from a team as a code owner January 22, 2022 06:42
@srikrishmurthy srikrishmurthy requested a review from a team January 22, 2022 06:42
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srikrishmurthy srikrishmurthy merged commit dddb10f into main Jan 24, 2022
@srikrishmurthy srikrishmurthy deleted the srikrishmurthy-patch-1 branch January 24, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants