Vault cluster scaling

[kkredit]

🛠️ Description

When changing vault cluster tiers, do not ForceNew.

* Vault cluster: fix to tier scaling [GH-233]

🏗️ Acceptance tests

• Are there any feature flags that are required to use this functionality?
• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[bcmdarroch]

successful e2e test with existing Vault cluster:

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # hcp_vault_cluster.vault-cluster will be updated in-place
  ~ resource "hcp_vault_cluster" "vault-cluster" {
        id                         = "/project/<id>/hashicorp.vault.cluster/vault-cluster"
      ~ tier                       = "DEV" -> "standard_small"
        # (11 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.
2021-12-09T10:49:56.980-0800 [DEBUG] command: asking for input: "\nDo you want to perform these actions?"

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes
...
(logs)
...
hcp_vault_cluster.vault-cluster: Modifications complete after 9m49s [id=/project/<id>/hashicorp.vault.cluster/vault-cluster]
2021-12-09T10:59:49.259-0800 [DEBUG] provider.stdio: received EOF, stopping recv loop: err="rpc error: code = Unavailable desc = transport is closing"
2021-12-09T10:59:49.262-0800 [DEBUG] provider: plugin process exited: path=.terraform/providers/localhost/providers/hcp/0.0.1/darwin_amd64/terraform-provider-hcp pid=99900
2021-12-09T10:59:49.262-0800 [DEBUG] provider: plugin exited

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.