From ebbf5327c13c2c5c6ab78867dbfcdd3382439542 Mon Sep 17 00:00:00 2001 From: Sarah French <15078782+SarahFrench@users.noreply.github.com> Date: Fri, 8 Dec 2023 17:47:32 +0000 Subject: [PATCH 01/10] Update CHANGELOG.md --- CHANGELOG.md | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index facc294d280..3223e4587b1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,33 @@ ## 5.9.0 (Unreleased) +FEATURES: +* **New Data Source:** `google_logging_folder_settings` ([#16658](https://github.com/hashicorp/terraform-provider-google/pull/16658)) +* **New Data Source:** `google_logging_organization_settings` ([#16658](https://github.com/hashicorp/terraform-provider-google/pull/16658)) +* **New Data Source:** `google_logging_project_settings` ([#16658](https://github.com/hashicorp/terraform-provider-google/pull/16658)) +* **New Data Source:** `google_vmwareengine_network_policy` ([#16639](https://github.com/hashicorp/terraform-provider-google/pull/16639)) +* **New Data Source:** `google_vmwareengine_nsx_credentials` ([#16669](https://github.com/hashicorp/terraform-provider-google/pull/16669)) +* **New Resource:** `google_scc_event_threat_detection_custom_module` ([#16649](https://github.com/hashicorp/terraform-provider-google/pull/16649)) +* **New Resource:** `google_secure_source_manager_instance` ([#16637](https://github.com/hashicorp/terraform-provider-google/pull/16637)) +* **New Resource:** `google_vmwareengine_network_policy` ([#16639](https://github.com/hashicorp/terraform-provider-google/pull/16639)) + +IMPROVEMENTS: +* bigqueryconnection - add `spark` support to `google_bigquery_connection` resource ([#16677](https://github.com/hashicorp/terraform-provider-google/pull/16677)) +* cloudidentity: added `expiry_detail` field to `google_cloud_identity_group_membership` resource ([#16643](https://github.com/hashicorp/terraform-provider-google/pull/16643)) +* container: added `queued_provisioning` field to `google_container_node_pool` resource ([#16623](https://github.com/hashicorp/terraform-provider-google/pull/16623)) +* container: promoted GKE Autoscaling Profiles to GA in the `cluster_autoscaling` block in `google_container_cluster` ([#16653](https://github.com/hashicorp/terraform-provider-google/pull/16653)) +* dlp: update required fields in `timespan_config` config block for `data_loss_prevention_job_trigger` resource ([#16628](https://github.com/hashicorp/terraform-provider-google/pull/16628)) +* gkehub: added `default_cluster_config` to `google_gke_hub_fleet` resource ([#16630](https://github.com/hashicorp/terraform-provider-google/pull/16630)) +* gkehub: added `binary_authorization_config` to `google_gke_hub_fleet` resource ([#16674](https://github.com/hashicorp/terraform-provider-google/pull/16674)) +REVERTED : * sql: added support for IAM GROUP authentication in the `type` field of `google_sql_user` ([#16681](https://github.com/hashicorp/terraform-provider-google/pull/16681)) +* sql: added support for in-place updates to the `edition` field in `google_sql_database_instance` ([#16629](https://github.com/hashicorp/terraform-provider-google/pull/16629)) + +BUG FIXES: +* container: made `dns_config` field updatable on `google_container_cluster` resource ([#16652](https://github.com/hashicorp/terraform-provider-google/pull/16652)) +* artifactregistry: fixed permadiff due to unsorted `virtual_repository_config` array in `google_artifact_registry_repository` ([#16646](https://github.com/hashicorp/terraform-provider-google/pull/16646)) +* firestore: retried resource creation for error 409 with the text "Aborted due to cross-transaction contention" in `google_firestore_index ` ([#16618](https://github.com/hashicorp/terraform-provider-google/pull/16618)) +* firestore: retried resource creation for error 409 with the text "Please retry, underlying data changed" in `google_firestore_index` ([#16670](https://github.com/hashicorp/terraform-provider-google/pull/16670)) +* storage: fixed unexpected `lifecycle_rule` conditions being added for `google_storage_bucket` ([#16683](https://github.com/hashicorp/terraform-provider-google/pull/16683)) + ## 5.8.0 (Dec 4, 2023) FEATURES: From 6c0c7a4deb2ae9aa0ba78a3ffef60b27cf9cccdf Mon Sep 17 00:00:00 2001 From: Sarah French <15078782+SarahFrench@users.noreply.github.com> Date: Fri, 8 Dec 2023 17:48:00 +0000 Subject: [PATCH 02/10] Remove changlog item for reverted PR --- CHANGELOG.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3223e4587b1..9fad3a3a476 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,7 +18,6 @@ IMPROVEMENTS: * dlp: update required fields in `timespan_config` config block for `data_loss_prevention_job_trigger` resource ([#16628](https://github.com/hashicorp/terraform-provider-google/pull/16628)) * gkehub: added `default_cluster_config` to `google_gke_hub_fleet` resource ([#16630](https://github.com/hashicorp/terraform-provider-google/pull/16630)) * gkehub: added `binary_authorization_config` to `google_gke_hub_fleet` resource ([#16674](https://github.com/hashicorp/terraform-provider-google/pull/16674)) -REVERTED : * sql: added support for IAM GROUP authentication in the `type` field of `google_sql_user` ([#16681](https://github.com/hashicorp/terraform-provider-google/pull/16681)) * sql: added support for in-place updates to the `edition` field in `google_sql_database_instance` ([#16629](https://github.com/hashicorp/terraform-provider-google/pull/16629)) BUG FIXES: From 7d1476bdbafbbcb17c86b592c3b4191a271ea791 Mon Sep 17 00:00:00 2001 From: Sarah French <15078782+SarahFrench@users.noreply.github.com> Date: Fri, 8 Dec 2023 18:21:56 +0000 Subject: [PATCH 03/10] Some phrasing changes, and put bug fixes in order --- CHANGELOG.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9fad3a3a476..e0af8fab2c9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,17 +14,17 @@ IMPROVEMENTS: * bigqueryconnection - add `spark` support to `google_bigquery_connection` resource ([#16677](https://github.com/hashicorp/terraform-provider-google/pull/16677)) * cloudidentity: added `expiry_detail` field to `google_cloud_identity_group_membership` resource ([#16643](https://github.com/hashicorp/terraform-provider-google/pull/16643)) * container: added `queued_provisioning` field to `google_container_node_pool` resource ([#16623](https://github.com/hashicorp/terraform-provider-google/pull/16623)) -* container: promoted GKE Autoscaling Profiles to GA in the `cluster_autoscaling` block in `google_container_cluster` ([#16653](https://github.com/hashicorp/terraform-provider-google/pull/16653)) +* container: promoted GKE Autoscaling Profiles to GA in the `cluster_autoscaling` block in `google_container_cluster` resource ([#16653](https://github.com/hashicorp/terraform-provider-google/pull/16653)) * dlp: update required fields in `timespan_config` config block for `data_loss_prevention_job_trigger` resource ([#16628](https://github.com/hashicorp/terraform-provider-google/pull/16628)) -* gkehub: added `default_cluster_config` to `google_gke_hub_fleet` resource ([#16630](https://github.com/hashicorp/terraform-provider-google/pull/16630)) -* gkehub: added `binary_authorization_config` to `google_gke_hub_fleet` resource ([#16674](https://github.com/hashicorp/terraform-provider-google/pull/16674)) -* sql: added support for in-place updates to the `edition` field in `google_sql_database_instance` ([#16629](https://github.com/hashicorp/terraform-provider-google/pull/16629)) +* gkehub: added `default_cluster_config` field to `google_gke_hub_fleet` resource ([#16630](https://github.com/hashicorp/terraform-provider-google/pull/16630)) +* gkehub: added `binary_authorization_config` field to `google_gke_hub_fleet` resource ([#16674](https://github.com/hashicorp/terraform-provider-google/pull/16674)) +* sql: added support for in-place updates to the `edition` field in `google_sql_database_instance` resource ([#16629](https://github.com/hashicorp/terraform-provider-google/pull/16629)) BUG FIXES: -* container: made `dns_config` field updatable on `google_container_cluster` resource ([#16652](https://github.com/hashicorp/terraform-provider-google/pull/16652)) * artifactregistry: fixed permadiff due to unsorted `virtual_repository_config` array in `google_artifact_registry_repository` ([#16646](https://github.com/hashicorp/terraform-provider-google/pull/16646)) -* firestore: retried resource creation for error 409 with the text "Aborted due to cross-transaction contention" in `google_firestore_index ` ([#16618](https://github.com/hashicorp/terraform-provider-google/pull/16618)) -* firestore: retried resource creation for error 409 with the text "Please retry, underlying data changed" in `google_firestore_index` ([#16670](https://github.com/hashicorp/terraform-provider-google/pull/16670)) +* container: made `dns_config` field updatable on `google_container_cluster` resource ([#16652](https://github.com/hashicorp/terraform-provider-google/pull/16652)) +* firestore: retried resource creation for error 409 with the text "Aborted due to cross-transaction contention" in `google_firestore_index` resource ([#16618](https://github.com/hashicorp/terraform-provider-google/pull/16618)) +* firestore: retried resource creation for error 409 with the text "Please retry, underlying data changed" in `google_firestore_index` resource ([#16670](https://github.com/hashicorp/terraform-provider-google/pull/16670)) * storage: fixed unexpected `lifecycle_rule` conditions being added for `google_storage_bucket` ([#16683](https://github.com/hashicorp/terraform-provider-google/pull/16683)) ## 5.8.0 (Dec 4, 2023) From 93e4f4dba112dfa038d96ed3920e9efd65b2d5a2 Mon Sep 17 00:00:00 2001 From: Sarah French <15078782+SarahFrench@users.noreply.github.com> Date: Fri, 8 Dec 2023 18:29:19 +0000 Subject: [PATCH 04/10] Update CHANGELOG.md Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e0af8fab2c9..9c3f042c574 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,7 +11,7 @@ FEATURES: * **New Resource:** `google_vmwareengine_network_policy` ([#16639](https://github.com/hashicorp/terraform-provider-google/pull/16639)) IMPROVEMENTS: -* bigqueryconnection - add `spark` support to `google_bigquery_connection` resource ([#16677](https://github.com/hashicorp/terraform-provider-google/pull/16677)) +* bigqueryconnection - added `spark` support to `google_bigquery_connection` resource ([#16677](https://github.com/hashicorp/terraform-provider-google/pull/16677)) * cloudidentity: added `expiry_detail` field to `google_cloud_identity_group_membership` resource ([#16643](https://github.com/hashicorp/terraform-provider-google/pull/16643)) * container: added `queued_provisioning` field to `google_container_node_pool` resource ([#16623](https://github.com/hashicorp/terraform-provider-google/pull/16623)) * container: promoted GKE Autoscaling Profiles to GA in the `cluster_autoscaling` block in `google_container_cluster` resource ([#16653](https://github.com/hashicorp/terraform-provider-google/pull/16653)) From dae323ca7dc9d8375cc511f6a62cef8a98c65ddd Mon Sep 17 00:00:00 2001 From: Sarah French <15078782+SarahFrench@users.noreply.github.com> Date: Fri, 8 Dec 2023 18:32:50 +0000 Subject: [PATCH 05/10] Update CHANGELOG.md Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9c3f042c574..0544232b4c2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,7 +14,7 @@ IMPROVEMENTS: * bigqueryconnection - added `spark` support to `google_bigquery_connection` resource ([#16677](https://github.com/hashicorp/terraform-provider-google/pull/16677)) * cloudidentity: added `expiry_detail` field to `google_cloud_identity_group_membership` resource ([#16643](https://github.com/hashicorp/terraform-provider-google/pull/16643)) * container: added `queued_provisioning` field to `google_container_node_pool` resource ([#16623](https://github.com/hashicorp/terraform-provider-google/pull/16623)) -* container: promoted GKE Autoscaling Profiles to GA in the `cluster_autoscaling` block in `google_container_cluster` resource ([#16653](https://github.com/hashicorp/terraform-provider-google/pull/16653)) +* container: promoted `autoscaling_profile` to GA in the `cluster_autoscaling` block in `google_container_cluster` resource ([#16653](https://github.com/hashicorp/terraform-provider-google/pull/16653)) * dlp: update required fields in `timespan_config` config block for `data_loss_prevention_job_trigger` resource ([#16628](https://github.com/hashicorp/terraform-provider-google/pull/16628)) * gkehub: added `default_cluster_config` field to `google_gke_hub_fleet` resource ([#16630](https://github.com/hashicorp/terraform-provider-google/pull/16630)) * gkehub: added `binary_authorization_config` field to `google_gke_hub_fleet` resource ([#16674](https://github.com/hashicorp/terraform-provider-google/pull/16674)) From 7ff559059b70de0910018441674ce450bbd4695e Mon Sep 17 00:00:00 2001 From: Sarah French <15078782+SarahFrench@users.noreply.github.com> Date: Fri, 8 Dec 2023 18:33:47 +0000 Subject: [PATCH 06/10] Update CHANGELOG.md Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com> --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0544232b4c2..462cb70ce48 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,7 +15,7 @@ IMPROVEMENTS: * cloudidentity: added `expiry_detail` field to `google_cloud_identity_group_membership` resource ([#16643](https://github.com/hashicorp/terraform-provider-google/pull/16643)) * container: added `queued_provisioning` field to `google_container_node_pool` resource ([#16623](https://github.com/hashicorp/terraform-provider-google/pull/16623)) * container: promoted `autoscaling_profile` to GA in the `cluster_autoscaling` block in `google_container_cluster` resource ([#16653](https://github.com/hashicorp/terraform-provider-google/pull/16653)) -* dlp: update required fields in `timespan_config` config block for `data_loss_prevention_job_trigger` resource ([#16628](https://github.com/hashicorp/terraform-provider-google/pull/16628)) +* dlp: updated required fields in `timespan_config` config block for `data_loss_prevention_job_trigger` resource ([#16628](https://github.com/hashicorp/terraform-provider-google/pull/16628)) * gkehub: added `default_cluster_config` field to `google_gke_hub_fleet` resource ([#16630](https://github.com/hashicorp/terraform-provider-google/pull/16630)) * gkehub: added `binary_authorization_config` field to `google_gke_hub_fleet` resource ([#16674](https://github.com/hashicorp/terraform-provider-google/pull/16674)) * sql: added support for in-place updates to the `edition` field in `google_sql_database_instance` resource ([#16629](https://github.com/hashicorp/terraform-provider-google/pull/16629)) From e1f4e0a0d5d8da2b24124e90527bf1d7c602f933 Mon Sep 17 00:00:00 2001 From: Sarah French <15078782+SarahFrench@users.noreply.github.com> Date: Fri, 8 Dec 2023 18:33:53 +0000 Subject: [PATCH 07/10] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 462cb70ce48..08b024ec522 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,7 +11,7 @@ FEATURES: * **New Resource:** `google_vmwareengine_network_policy` ([#16639](https://github.com/hashicorp/terraform-provider-google/pull/16639)) IMPROVEMENTS: -* bigqueryconnection - added `spark` support to `google_bigquery_connection` resource ([#16677](https://github.com/hashicorp/terraform-provider-google/pull/16677)) +* bigqueryconnection: added `spark` support to `google_bigquery_connection` resource ([#16677](https://github.com/hashicorp/terraform-provider-google/pull/16677)) * cloudidentity: added `expiry_detail` field to `google_cloud_identity_group_membership` resource ([#16643](https://github.com/hashicorp/terraform-provider-google/pull/16643)) * container: added `queued_provisioning` field to `google_container_node_pool` resource ([#16623](https://github.com/hashicorp/terraform-provider-google/pull/16623)) * container: promoted `autoscaling_profile` to GA in the `cluster_autoscaling` block in `google_container_cluster` resource ([#16653](https://github.com/hashicorp/terraform-provider-google/pull/16653)) From 13704bb536e0f495264caf686c4af315807096ca Mon Sep 17 00:00:00 2001 From: Sarah French <15078782+SarahFrench@users.noreply.github.com> Date: Fri, 8 Dec 2023 19:12:06 +0000 Subject: [PATCH 08/10] Remove beta-only changelog item --- CHANGELOG.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 08b024ec522..8b11207db8b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,7 +13,6 @@ FEATURES: IMPROVEMENTS: * bigqueryconnection: added `spark` support to `google_bigquery_connection` resource ([#16677](https://github.com/hashicorp/terraform-provider-google/pull/16677)) * cloudidentity: added `expiry_detail` field to `google_cloud_identity_group_membership` resource ([#16643](https://github.com/hashicorp/terraform-provider-google/pull/16643)) -* container: added `queued_provisioning` field to `google_container_node_pool` resource ([#16623](https://github.com/hashicorp/terraform-provider-google/pull/16623)) * container: promoted `autoscaling_profile` to GA in the `cluster_autoscaling` block in `google_container_cluster` resource ([#16653](https://github.com/hashicorp/terraform-provider-google/pull/16653)) * dlp: updated required fields in `timespan_config` config block for `data_loss_prevention_job_trigger` resource ([#16628](https://github.com/hashicorp/terraform-provider-google/pull/16628)) * gkehub: added `default_cluster_config` field to `google_gke_hub_fleet` resource ([#16630](https://github.com/hashicorp/terraform-provider-google/pull/16630)) From 942ecd0cb3e5e00e7bb53762659d0db6d4333351 Mon Sep 17 00:00:00 2001 From: Sarah French <15078782+SarahFrench@users.noreply.github.com> Date: Fri, 8 Dec 2023 19:24:34 +0000 Subject: [PATCH 09/10] Clarify dlp release note --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8b11207db8b..59f40749b39 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,7 +14,6 @@ IMPROVEMENTS: * bigqueryconnection: added `spark` support to `google_bigquery_connection` resource ([#16677](https://github.com/hashicorp/terraform-provider-google/pull/16677)) * cloudidentity: added `expiry_detail` field to `google_cloud_identity_group_membership` resource ([#16643](https://github.com/hashicorp/terraform-provider-google/pull/16643)) * container: promoted `autoscaling_profile` to GA in the `cluster_autoscaling` block in `google_container_cluster` resource ([#16653](https://github.com/hashicorp/terraform-provider-google/pull/16653)) -* dlp: updated required fields in `timespan_config` config block for `data_loss_prevention_job_trigger` resource ([#16628](https://github.com/hashicorp/terraform-provider-google/pull/16628)) * gkehub: added `default_cluster_config` field to `google_gke_hub_fleet` resource ([#16630](https://github.com/hashicorp/terraform-provider-google/pull/16630)) * gkehub: added `binary_authorization_config` field to `google_gke_hub_fleet` resource ([#16674](https://github.com/hashicorp/terraform-provider-google/pull/16674)) * sql: added support for in-place updates to the `edition` field in `google_sql_database_instance` resource ([#16629](https://github.com/hashicorp/terraform-provider-google/pull/16629)) @@ -22,6 +21,8 @@ IMPROVEMENTS: BUG FIXES: * artifactregistry: fixed permadiff due to unsorted `virtual_repository_config` array in `google_artifact_registry_repository` ([#16646](https://github.com/hashicorp/terraform-provider-google/pull/16646)) * container: made `dns_config` field updatable on `google_container_cluster` resource ([#16652](https://github.com/hashicorp/terraform-provider-google/pull/16652)) +* dlp: added conflicting field validation in the `storage_config.timespan_config` block in `data_loss_prevention_job_trigger` resource ([#16628](https://github.com/hashicorp/terraform-provider-google/pull/16628)) +* dlp: updated the `storage_config.timespan_config.timestamp_field` field in `data_loss_prevention_job_trigger` to be optional ([#16628](https://github.com/hashicorp/terraform-provider-google/pull/16628)) * firestore: retried resource creation for error 409 with the text "Aborted due to cross-transaction contention" in `google_firestore_index` resource ([#16618](https://github.com/hashicorp/terraform-provider-google/pull/16618)) * firestore: retried resource creation for error 409 with the text "Please retry, underlying data changed" in `google_firestore_index` resource ([#16670](https://github.com/hashicorp/terraform-provider-google/pull/16670)) * storage: fixed unexpected `lifecycle_rule` conditions being added for `google_storage_bucket` ([#16683](https://github.com/hashicorp/terraform-provider-google/pull/16683)) From 02b23c4fd76b531b1904967aa28f847cf478e191 Mon Sep 17 00:00:00 2001 From: Sarah French <15078782+SarahFrench@users.noreply.github.com> Date: Mon, 11 Dec 2023 13:22:30 +0000 Subject: [PATCH 10/10] Combine firestore changelog entries --- CHANGELOG.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 59f40749b39..c311caf6211 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,8 +23,7 @@ BUG FIXES: * container: made `dns_config` field updatable on `google_container_cluster` resource ([#16652](https://github.com/hashicorp/terraform-provider-google/pull/16652)) * dlp: added conflicting field validation in the `storage_config.timespan_config` block in `data_loss_prevention_job_trigger` resource ([#16628](https://github.com/hashicorp/terraform-provider-google/pull/16628)) * dlp: updated the `storage_config.timespan_config.timestamp_field` field in `data_loss_prevention_job_trigger` to be optional ([#16628](https://github.com/hashicorp/terraform-provider-google/pull/16628)) -* firestore: retried resource creation for error 409 with the text "Aborted due to cross-transaction contention" in `google_firestore_index` resource ([#16618](https://github.com/hashicorp/terraform-provider-google/pull/16618)) -* firestore: retried resource creation for error 409 with the text "Please retry, underlying data changed" in `google_firestore_index` resource ([#16670](https://github.com/hashicorp/terraform-provider-google/pull/16670)) +* firestore: added retries during creation of `google_firestore_index` resources to address retryable 409 code API errors ("Please retry, underlying data changed", and "Aborted due to cross-transaction contention") ([#16618](https://github.com/hashicorp/terraform-provider-google/pull/16618), [#16670](https://github.com/hashicorp/terraform-provider-google/pull/16670)) * storage: fixed unexpected `lifecycle_rule` conditions being added for `google_storage_bucket` ([#16683](https://github.com/hashicorp/terraform-provider-google/pull/16683)) ## 5.8.0 (Dec 4, 2023)