Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta: Support for Cloud Build Worker Pools #8985

Closed
carlpett opened this issue Apr 23, 2021 · 5 comments · Fixed by GoogleCloudPlatform/magic-modules#4877, hashicorp/terraform-provider-google-beta#3372 or #9417
Assignees
Labels
enhancement priority/1 size/m tpgtools Issues related to the tpgtools generator

Comments

@carlpett
Copy link
Contributor

carlpett commented Apr 23, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Cloud Build worker pools is available through gcloud beta for projects which are part of the preview. Would be great to be able to create them using Terraform!

New or Affected Resource(s)

  • google_cloudbuild_worker_pool

Potential Terraform Configuration

resource "google_cloudbuild_worker_pool" "my-pool" {
  name = "my-pool"
  region = "us-central1"

  # Optional
  peered_network = "projects/my-project/global/networks/my-network" # Default un-peered
  disable_public_ip = True # Default false
  worker_machine_type = "e2-medium"
  worker_machine_disk_size = "100G"
}

References

  • b/182597571
@rileykarson rileykarson added the tpgtools Issues related to the tpgtools generator label May 3, 2021
@rileykarson
Copy link
Collaborator

Note: this is / will be available in the DCL

@rileykarson rileykarson added this to the Goals milestone May 3, 2021
@carlpett
Copy link
Contributor Author

carlpett commented May 3, 2021

Great, but, eh, what is the DCL? 😅

@rileykarson
Copy link
Collaborator

rileykarson commented May 3, 2021

Notes that I add to issues are generally added during a team triage meeting so I don't completely flesh out the details, sorry about that! The DCL ('declarative client library') is https://github.com/GoogleCloudPlatform/declarative-resource-client-library, a client library for declarative tooling like TF which substantially simplifies the implementation of new resources.

@rileykarson rileykarson removed this from the Goals milestone May 3, 2021
@carlpett
Copy link
Contributor Author

carlpett commented May 3, 2021

Oh, okay, thanks for the explanation!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.