google_project_access_approval_settings doesn't respect the project_id field

[supersmo]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
• Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.
• If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

0.14.4

Affected Resource(s)

• google_project_access_approval_settings

Terraform Configuration Files

# Copy-paste your Terraform configurations here.
#
# For large Terraform configs, please use a service like Dropbox and share a link to the ZIP file.
# For security, you can also encrypt the files using our GPG public key:
#    https://www.hashicorp.com/security
#
# If reproducing the bug involves modifying the config file (e.g., apply a config,
# change a value, apply the config again, see the bug), then please include both:
# * the version of the config before the change, and
# * the version of the config after the change.
terraform {
  required_providers {
    google = { }
  }
}

provider "google" {
  project = var.default_project_id
  region  = var.default_region
  zone    = var.default_zone
}

resource "google_project_access_approval_settings" "project_access_approval" {
  project_id          = var.some_other_project_id
  notification_emails = [var.notification_email]

  enrolled_services {
    cloud_product = "all"
    enrollment_level = "BLOCK_ALL"
  }
}

Expected Behavior

It should attempt to activate access approval on the specified project.

Actual Behavior

It tries to activate access approval on the default project specified in the google provider block.

Steps to Reproduce

1. terraform apply

Comment

I'm suspecting that the attribute in the google_project_access_approval_settings block should be renamed from project_id to project since the only other terraform resource that uses project_id (as far as I know) is google_project, all other resources use a project attribute to specify the project.

[venkykuberan]

@supersmo project_id isn't read from the config in the resource Create call. We will fix it.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!