Make scheduling node_affinities updatable

[c2thorn]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

The Compute API allows node_affinities to be updated when the instance is stopped: https://cloud.google.com/compute/docs/reference/rest/v1/instances/setScheduling

This can allow users to move VMs to sole tenancy without destroying and recreating their instances. Right now we have the field set as ForceNew. We should remove ForceNew from the field/sub-fields, and modify schedulingHasChange to detect changes on node_affinities.

The API documentation states that setScheduling requires the instance to be stopped, but it seems that this is only true to update node_affinities. We should determine if it is right to move the entire setScheduling call to after we stop the instance, or if the instance should only be stopped for updating node_affinities.

New or Affected Resource(s)

• google_compute_instance

References

• b/174512356

[rileykarson]

Note: there's an outstanding PR but we need someone on our team (likely @c2thorn) to pick it up. Assigning to a future sprint for now.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!