Add support for Google Virtual Network Interface (gVNIC)

[rileykarson]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

https://cloud.google.com/compute/docs/instances/create-vm-with-gvnic

Will appear as the networkInterfaces[].nicType field, which doesn't currently appear in the docs

New or Affected Resource(s)

• google_compute_instance

Potential Terraform Configuration

  network_interfaces {
    ...

    nic_type = "GVNIC"
  }

References

• b/171435195 (internal)

[upodroid]

This doesn't exist in the generated go client yet.

https://raw.githubusercontent.com/googleapis/google-api-go-client/master/compute/v0.beta/compute-gen.go and search for "type NetworkInterface"

Also:

• We need to add GVNIC to this enum too:
  https://github.com/GoogleCloudPlatform/magic-modules/blob/6c09b5a5a9a9cff255cd074f433d4d446c24c705/products/compute/api.yaml#L5547
• Amend the Instance Template as well.

https://pkg.go.dev/google.golang.org/api/compute/v0.beta#NetworkInterface

[rileykarson]

Moving into Sprint 26 for the assignee to re-investigate. We can move this back out if it's still not available.

[edwardmedia]

Using pre-configured images works (like below)

  boot_disk {
    initialize_params {
      image = "beta/projects/gvnic-vm-image-prod/global/images/family/debian-9-gvnic"
    }
  }

[rileykarson]

note: I filed this issue describing a part of the upcoming GA API, which doesn't appear to be a part of the beta API. Whoops! At beta, we just need to ensure we can enable gvnic under guestOsFeatures[].type.

[rileykarson]

@edwardmedia: The instance part of this API should be available now. When you have the chance, mind giving it a try?

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!