Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_bigquery_table doesn't support ORC format #7691

Comments

@laurenemms
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v0.13.5
+ provider registry.terraform.io/hashicorp/google v3.45.0

Affected Resource(s)

google_bigquery_table

Terraform Configuration Files

resource "google_bigquery_table" "some_table" {
  dataset_id = "some_dataset"
  table_id = "some_table"

  external_data_configuration {
    autodetect  = true
    source_format = "ORC"
    source_uris = [
      "gs://bucket-name/*"
    ]
    hive_partitioning_options {
      mode = "CUSTOM"
      source_uri_prefix = "gs://bucket-name/{date:DATE}"
    }
  }
}

Expected Behavior

Should be able to create a table from a bucket with ORC data. This works from the API.

Actual Behavior

Error: expected external_data_configuration.0.source_format to be one of [CSV GOOGLE_SHEETS NEWLINE_DELIMITED_JSON AVRO DATSTORE_BACKUP PARQUET], got ORC

Steps to Reproduce

terraform apply

References

Orc is listed as supported: https://cloud.google.com/bigquery/external-data-cloud-storage and works when hitting the API

@ghost ghost added the bug label Nov 2, 2020
@venkykuberan venkykuberan self-assigned this Nov 2, 2020
@upodroid
Copy link
Contributor

upodroid commented Nov 2, 2020

@venkykuberan there is another identical issue for the same field.

#7653

Someone is working on it with an open PR that you can piggy back.

@venkykuberan
Copy link
Contributor

Thank you @upodroid.

@laurenemms i am closing this issue as a duplicate. We have a work in progress here #7653 for the same field. I requested to include ORC in the source_format list.

@laurenemms
Copy link
Author

Thank you @upodroid.

@laurenemms i am closing this issue as a duplicate. We have a work in progress here #7653 for the same field. I requested to include ORC in the source_format list.

Hi! Is it possible to reopen this? I noticed that this change was considered out of scope of that PR.

@upodroid
Copy link
Contributor

I don't agree with the assesment in https://github.com/GoogleCloudPlatform/magic-modules/pull/4155/files#r520275350

Tests are not required for relaxing ValidateFuncs. It is the job of the enduser to supply valid values.

@slevenick Do you agree?

@slevenick
Copy link
Collaborator

I'd say it could be added to that PR, but I wouldn't require them to add it. I'll reopen this as the format can be added in a separate PR

@ghost
Copy link

ghost commented Dec 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.