Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_dataflow_job zone should not be required if region is specified #7642

Closed
jcanseco opened this issue Oct 27, 2020 · 3 comments · Fixed by GoogleCloudPlatform/magic-modules#4168, hashicorp/terraform-provider-google-beta#2662 or #7703
Assignees
Labels
bug forward/review In review; remove label to forward service/dataflow

Comments

@jcanseco
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v0.12.24
+ provider.google v3.44.0

Affected Resource(s)

  • google_dataflow_job

Terraform Configuration Files

provider "google" {
  project = "my-project"
}

resource "google_storage_bucket" "bucket" {
  name = "my-bucket"
  force_destroy = true
}

resource "google_dataflow_job" "job" {
  name = "my-job"
  region = "us-central1"
  template_gcs_path = "gs://dataflow-templates/latest/Word_Count"
  temp_gcs_location = google_storage_bucket.bucket.url
  parameters = {
    inputFile = "gs://dataflow-samples/shakespeare/various.txt"
    output = "${google_storage_bucket.bucket.url}/output"
  }
  on_delete = "cancel"
}

Expected Behavior

Job should be created successfully.

Actual Behavior

Job failed to create due to zone being required despite region being specified. This is inconsistent with Dataflow API behavior.

google_dataflow_job.job: Creating...                                                                                                                                                  
                                                                                                                                                                                      
Error: Cannot determine zone: set in this resource, or set provider-level zone.  

Steps to Reproduce

  1. terraform apply
@venkykuberan
Copy link
Contributor

Agree, Zone isn't required when region is given in the config. Able to create hit the API with just region to create a data flow job

@jcanseco
Copy link
Contributor Author

jcanseco commented Nov 2, 2020

Thanks for getting to this issue so quickly @venkykuberan!

@ghost
Copy link

ghost commented Nov 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 30, 2020
@github-actions github-actions bot added forward/review In review; remove label to forward service/dataflow labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.