Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_billing_budget add support for disable_default_iam_recipients #7419

Closed
nahz opened this issue Oct 3, 2020 · 2 comments · Fixed by GoogleCloudPlatform/magic-modules#4050, hashicorp/terraform-provider-google-beta#2606 or #7544
Assignees
Milestone

Comments

@nahz
Copy link

nahz commented Oct 3, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

An enhancement was recently made to the Billing Budgets API billingbudgets.googleapis.com.

The allUpdatesRule object now has a field to disableDefaultIamRecipients.

This adds the option to opt out of the default email settings, choosing not to send budget alert emails to Billing Account Administrators and Billing Account Users.

New or Affected Resource(s)

  • google_billing_budget

Potential Terraform Configuration

resource "google_billing_budget" "budget" {
  ...
  all_updates_rule {
    ...
    disable_default_iam_recipients = true
  }
}

References

This enhancement was added to the API on 28-Sep-2020, see release notes

@ghost ghost added the enhancement label Oct 3, 2020
@nahz
Copy link
Author

nahz commented Oct 3, 2020

... and I'm already looking at adding this functionality myself.
Branch is over here: https://github.com/nahz/magic-modules/tree/update-product-billingbudget-defaultrecipients

@ghost
Copy link

ghost commented Nov 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.