Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new Cloud Logging API v2 features #7342

Closed
c2thorn opened this issue Sep 23, 2020 · 3 comments
Closed

Support new Cloud Logging API v2 features #7342

c2thorn opened this issue Sep 23, 2020 · 3 comments

Comments

@c2thorn
Copy link
Collaborator

c2thorn commented Sep 23, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Cloud Logging API v2 has released to GA and offers more features for google_logging_*_bucket_config and google_logging_*_sink resources.

New or Affected Resource(s)

google_logging_*_bucket_config:
Users can actually create logs buckets and specify custom bucket ID's. Currently the Terraform resource only acquires existing buckets.

google_logging_*_sink
Users can specify a custom bucket as the sink destination. I believe this should already be possible in the provider now, but we should verify and update the documentation at least.

References

  • b/168297756
@ghost ghost added the enhancement label Sep 23, 2020
@upodroid
Copy link
Contributor

FYI, saw this PR that implements exclusions.

#7335

@c2thorn
Copy link
Collaborator Author

c2thorn commented Sep 28, 2020

Hi folks,

I named this issue pretty ambiguously, so we wanted to clarify what we are committing to so far. We split this up by specific feature request and created #7371 and #7372 .

I am closing this, but if you have a separate feature that is a part of Cloud Logging API v2 please create a new feature request issue.

@c2thorn c2thorn closed this as completed Sep 28, 2020
@ghost
Copy link

ghost commented Oct 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants