Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource google_compute_network, delete_default_routes_on_create flag not working with recent change of ComputeDefaultBasePath #7243

Closed
riteshnanda09 opened this issue Sep 10, 2020 · 3 comments
Assignees
Labels

Comments

@riteshnanda09
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v0.12.26
+ provider.google v3.38.0

Affected Resource(s)

  • google_compute_network

Expected Behavior

default routes (0.0.0.0/0) will be deleted immediately after network creation.

Actual Behavior

default routes (0.0.0.0/0) was not deleted. looks like the url we build for the network filter uses ComputeDefaultBasePath which points to https://compute.googleapis.com/compute/v1/ instead it should be using https://www.googleapis.com/compute/v1/ specifically for route url.

I know we might want to use actual service url in this commit , but it breaks routes deletion during network creation.

@ghost ghost added bug labels Sep 10, 2020
@McVillano
Copy link

Same problem here, default routes are not being deletd

@edwardmedia edwardmedia self-assigned this Sep 11, 2020
@edwardmedia
Copy link
Contributor

@riteshnanda09 @McVillano looks like this is a dup issue. #7164.
Please follow it for the resolution. Thanks

@ghost
Copy link

ghost commented Oct 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants