Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting hivePartitioningOptions offered in table.insert in the TF external_data_configuration block #6487

Closed
megaz94 opened this issue May 29, 2020 · 2 comments

Comments

@megaz94
Copy link

megaz94 commented May 29, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Terraform BigQuery currently does not support ExternalDataConfiguration > hivePartitioningOptions. At the time of writing this message, terraform supports 2 ExternalDataConfiguration options: csvOptions and googleSheetsOptions.

Potential Terraform Configuration

At this time, there is no configuration workaround.

As a hint for the terraform team, note that the constructions of table.insert for hivePartitioningOptions must have the following form:

{
tableReference {},
externalDataConfiguration{schema {}, hivePartitioningOptions{}} // putting the schema inside externalDataConfiguration and not in the outer scope
}

Constructing the JSON in the following way is incorrect and doesn't propagate the hive_keys correctly to the BQ destination table:

{
tableReference {},
schema {},
externalDataConfiguration{hivePartitioningOptions{}}
}
@ghost ghost added the enhancement label May 29, 2020
@megaz94 megaz94 changed the title Support Supporting hivePartitioningOptions for table.insert May 29, 2020
@megaz94 megaz94 changed the title Supporting hivePartitioningOptions for table.insert Supporting hivePartitioningOptions offered in table.insert May 29, 2020
@megaz94 megaz94 changed the title Supporting hivePartitioningOptions offered in table.insert Supporting hivePartitioningOptions offered in table.insert in the TF external_data_configuration block May 29, 2020
@danawillow
Copy link
Contributor

Duplicate of #5664. The feature has been merged so I think it'll show up in next Monday's release.

@ghost
Copy link

ghost commented Jul 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants