Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IAM conditions support for folder iam member #6093

Closed

Comments

@taylorludwig
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Similar to hashicorp/terraform-provider-google-beta#1321

Trying to add IAM conditions to google_folder_iam_member results in errors.

When applying, the condition does get created but then terraform gives a provider "registry.terraform.io/-/google-beta" produced an unexpected new value for was present, but now absent. error.

looking at the DEBUG logs I see that when requesting the policy after creation (https://github.com/terraform-providers/terraform-provider-google-beta/blob/master/google-beta/iam_folder.go#L103) the conditions aren't returned in the response. The following shows up in the logs Binding for role "roles/container.admin" with condition <title>/<description>/<expression> does not exist in policy of folder "folders/<folder>", removing member "group:<group>" from state

New or Affected Resource(s)

  • google_folder_iam_member

Potential Terraform Configuration

resource "google_folder_iam_member" "folder_iam_member" {
  provider = google-beta

  folder = var.folder
  role   = roles/container.admin
  member = "group:${var.group}"

  condition {
    title       =  "some_title"
    description = "description"
    expression  = "request.time < timestamp(\"2020-04-11T00:00:00-07:00\")"
  }

References

@ghost ghost added the enhancement label Apr 10, 2020
@danawillow danawillow added this to the Goals milestone Apr 13, 2020
@upodroid
Copy link
Contributor

upodroid commented Aug 6, 2020

This was released with provider version 3.30 https://github.com/hashicorp/terraform-provider-google/blob/master/CHANGELOG.md

I'll open a PR to update the docs.

@ghost
Copy link

ghost commented Sep 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.