Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DialogueFlow fulfillment support #6086

Assignees
Labels
Milestone

Comments

@rangerscience
Copy link

rangerscience commented Apr 9, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Support for setting DialogueFlow's fulfillment webhook.

New or Affected Resource(s)

  • google_dialogflow_agent

Potential Terraform Configuration

resource "google_dialogflow_agent" "full_agent" {
  //..
  fulfillment: {
    uri = heroku_app.my_app.web_url
    username = "admin"
    password = "somethingSomething"
    request_headers = { ... }
  }
}

References

API Docs:
https://cloud.google.com/dialogflow/docs/reference/rest/v2/projects.agent/getFulfillment
https://cloud.google.com/dialogflow/docs/reference/rest/v2/projects.agent/updateFulfillment
https://cloud.google.com/dialogflow/docs/reference/rest/v2/Fulfillment

  • #0000
@ghost ghost added the enhancement label Apr 9, 2020
@rangerscience
Copy link
Author

I'm interested in working on this myself, but I'm really not sure how to get started (particularly with regards to the modular magician). If someone would be so nice as to point me at some resources for that, I'll see what I can do.

@c2thorn
Copy link
Collaborator

c2thorn commented Apr 9, 2020

Hi @rangerscience thanks for creating this, and for your interest in contributing! The Magic Modules repo README is definitely the best place to get you started. It has a link to a codelab that will give you an overview of Magic Modules and how to create resources.

Looking over Dialogflow Fulfillments specifically, it seems that this would be best created as another resource, similar to Intents PR. Feel free to take a look at that PR as well. Fulfillments is much smaller than Intents, so there won't be as many fields to add in the api.yaml file.

If you get going, I'd be happy to help and review your pull request. Otherwise, this will get tracked and prioritized as normal.

@rangerscience
Copy link
Author

Fantastic :) I'm keeping an eye out for time to put into this, but releasing the stable features is taking priority (as they're the first features, this is pretty understandable....)

@jcanizalez
Copy link
Contributor

Hi team I hope you don't mind but I raised a PR to fix this issue GoogleCloudPlatform/magic-modules#4808

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2021
@github-actions github-actions bot added forward/review In review; remove label to forward service/dialogflow labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.