Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipip protocol missing from google_compute_firewall documentation #6032

Closed
Jberlinsky opened this issue Apr 2, 2020 · 2 comments
Closed

ipip protocol missing from google_compute_firewall documentation #6032

Jberlinsky opened this issue Apr 2, 2020 · 2 comments

Comments

@Jberlinsky
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

The documentation for the google_compute_firewall resource lists a set of protocols that can be allowed/denied, but it is missing ipip, which is supported in GCP APIs. Creating a firewall rule (see below) for ipip protocols succeeds, so this is a documentation-only update.

New or Affected Resource(s)

  • google_compute_firewall

Potential Terraform Configuration

// Copyright 2020 Google LLC. This software is provided as is, without warranty or representation for any use or purpose. Your use of it is subject to your agreement with Google.

resource "google_compute_firewall" "default_deny-ipip" {
  name     = "default-deny-ipip"
  project  = ...
  network  = ...
  priority = 65535

  deny {
    protocol = "ipip"
  }
}

References

N/A

@danawillow
Copy link
Contributor

Added in #6033.

@ghost
Copy link

ghost commented May 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants